Async support #209
Closed
Async support #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated methods in `directory.rs`, `files.rs`, `lib.rs`, `mod.rs`, and `volume_mgr.rs` to be async. - Added `maybe_async` attributes to conditionally compile sync/async versions based on feature flags. - Modified method implementations to await asynchronous calls where necessary. - Ensured compatibility with both async and sync contexts throughout the filesystem and volume management code.
Member
|
Thank you for this PR. Unfortunately this is a big PR with no tests and no explanation of what it does or why it does it. We’re going to need a bunch of examples and documentation updates before this can go in. If you’re asking me to take on ongoing maintenance for an API I have no need for, you’ll need to convince me it’s correct first and that I’m not just opening myself up for a slew of bug reports. I’m also going to insist that the async feature is off by default. |
Author
|
Hello! I am sorry for this PR. I will keep working on the branch, adding the tests, and fixing clippy warnings. |
Member
|
I don't mind seeing the PR left open as a draft! Feel free to @ me when you think you've got good test coverage ... which I guess you'd do with Tokio? Not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.